Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select the closest key on swipe #138

Merged
merged 5 commits into from
May 8, 2022
Merged

Select the closest key on swipe #138

merged 5 commits into from
May 8, 2022

Commits on May 8, 2022

  1. use the closest swipe key on swipe 

    fix a direction
    @Rodrigodd @Julow
    Rodrigodd authored and Julow committed May 8, 2022
    Configuration menu
    Copy the full SHA
    bc5581d View commit details
    Browse the repository at this point in the history

  2. only vibrate when the swipe key changes

    @Rodrigodd @Julow
    Rodrigodd authored and Julow committed May 8, 2022
    Configuration menu
    Copy the full SHA
    d66fce3 View commit details
    Browse the repository at this point in the history

  3. Improve nearest key computation 

    getAtDirection was too hard to maintain and might contain bugs.
Change slightly the meaning of directions and implement a the nearest
key calculation as a loop.
    @Julow
    Julow committed May 8, 2022
    Configuration menu
    Copy the full SHA
    4ade6ea View commit details
    Browse the repository at this point in the history

  4. Better handling of removed keys and swipe geture 

    The "closest key" logic must be careful not to reveal keys removed by a
modifier.

Must check [_handler.onPointerSwipe] for every candidate values.
[selected_value] is changed back to [selected_direction].

This adds a new bug: When the direction change, the selected value might
not change but a vibration will be triggered anyway.
    @Julow
    Julow committed May 8, 2022
    Configuration menu
    Copy the full SHA
    c3ef6b5 View commit details
    Browse the repository at this point in the history

  5. Fix vibration when pointer move slightly 

    Fix the bug introduced in the parent commit.
    @Julow
    Julow committed May 8, 2022
    Configuration menu
    Copy the full SHA
    21d17c2 View commit details
    Browse the repository at this point in the history