Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create latn_qwerty_tly.xml #529

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Create latn_qwerty_tly.xml #529

merged 3 commits into from
Jan 28, 2024

Conversation

vedamanavi
Copy link
Contributor

No description provided.

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some keys are present twice on the layout: a, c, g, j, q.

<row>
<key shift="0.5" key0="á" key2="`" key4="a"/>
<key key0="s" key2="~"/>
<key key0="d" key1="{" key4="loc "/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key4 doesn't look useful.

<key key0="q" key3="&amp;" key4="ğ"/>
</row>
<row>
<key shift="0.5" key0="á" key2="`" key4="a"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should drop this shift="0.5" attribute:

shot

(some symbols are added by my own configuration)

@Julow
Copy link
Owner

Julow commented Jan 28, 2024

Ping. I plan to release soon and this could be part of it if it's ready.

@vedamanavi
Copy link
Contributor Author

Ping. I plan to release soon and this could be part of it if it's ready.

Hi. Thanks for your support. I kindly request that you keep duplicate letters if possible, because It has not been long since Talysh-speaking people began writing in their language. In the southeast corner of each key, I have placed the corresponding Azerbaijani letter for each Talysh letter. Including duplicate letters will assist Talysh speakers in writing in their language, as most Talysh people are educated in the Azerbaijani language. However, if you believe that duplicate letters should not be included on the keyboard, I will respectfully abide by your decision.

@Julow
Copy link
Owner

Julow commented Jan 28, 2024

Hi! If the duplicated keys are intended, then it's completely fine!

applying suggested suggestions
@vedamanavi
Copy link
Contributor Author

vedamanavi commented Jan 28, 2024

Ping. I plan to release soon and this could be part of it if it's ready.

Thanks for your help and kindness. I have now applied the suggestions in the conversation and the layout is ready now. I would be grateful if you add in the next release.

@Julow Julow merged commit 44f3905 into Julow:master Jan 28, 2024
3 checks passed
@Julow
Copy link
Owner

Julow commented Jan 28, 2024

The layout looks nice, thanks :)
I've updated the generated files and pushed to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants