Gujarati phonetic layout #562
Conversation
check_layout.output
Outdated
| @@ -50,6 +50,10 @@ Layout doesn't define some important keys, missing: f11_placeholder, f12_placeho | |||
| # grek_qwerty | |||
| Duplicate keys: ; | |||
| 1 warnings | |||
| # guj_phonetic_in | |||
| Duplicate keys: +, -, =, _, `, ટ, ડ | |||
There was a problem hiding this comment.
This indicates symbols that are present twice on the layout. This wastes some space and looks weird.
| @@ -0,0 +1,49 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <keyboard name="ગુજરાતી ફોનેટિક - Gujarati Phonetic" script="gujarati"> | |||
| <row> | |||
There was a problem hiding this comment.
The top row doesn't look good in combination to the built-in number row (that can be enabled in the settings). Do you think every users of this layout will want to have this row ?
Also, the layout is very high due to top row. It takes almost half of the screen on my device. You can make the top row a bit smaller with height="0.75" (like the built-in number row).
There was a problem hiding this comment.
we can do something like this to remove the top row. [**also as you see in the Screen Shot, numbers are shown properly in keyboard but output is not in devanagari. I feel like there is a bug. Devanagari numbers work fine in normal view, just this number view is not working proper]
normal working in below view:
There was a problem hiding this comment.
The devanagari digits are specified here: https://github.com/Julow/Unexpected-Keyboard/blob/master/srcs/juloo.keyboard2/KeyModifier.java#L1060
Are they wrong ?
To change the numpad digits when your layout is visible, you'd need to add a new similar map and call it from here: https://github.com/Julow/Unexpected-Keyboard/blob/master/srcs/juloo.keyboard2/KeyModifier.java#L100
There was a problem hiding this comment.
The first screen shot just shows the layout in Devanagari(or any other language), but when typing, it puts output as english numbers. I think it is using values from https://github.com/Julow/Unexpected-Keyboard/blob/master/res/xml/numeric.xml .
I tried adding Gujarati number in the java file you suggested, but had same issue as mentioned above.
Edit: just tested by adding Gujarati numbers to the numeric.xml , it is outputting values we define there. the KeyModifier.java->modify_numpad_script is just for UI part. actual output comes from xml mapping.
(Sorry but I am not a android/java/kotlin developer, just did some debugging. : )
There was a problem hiding this comment.
You are right, there's a serious bug in the numpad. I fixed it in 8c7559d and fixed the number row in 8b5d971.
You can now remove the number row from your layout and enable the number row in the settings.
Note that the layout must also contain the numerals for people that don't use the number row option.
|
I could not find option to enable script specific numeric row, hence currently adding first row permanent and have made changes to row height so that it does not take up space. Now the layout looks quite good and feels almost same as experience on PC. No issue in merging it. Numeric layout related issue can be done in another pull/issue. |
Yogesh-B
force-pushed
the
gujarati_phonetic_layout
branch
from
af38837
to
da0a206
Compare
|
Now that the number row and numpad are fixed on master, could you pull master and update the layout ? I've added support for the gujarati numerals in this branch: https://github.com/Julow/Unexpected-Keyboard/tree/gujarati_numpad_script |
Yogesh-B
force-pushed
the
gujarati_phonetic_layout
branch
from
da0a206
to
03287b3
Compare
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
| <keyboard name="ગુજરાતી ફોનેટિક - Gujarati Phonetic" script="gujarati"> | ||
| <row> | ||
| <key key0="ટ" key1="`" key2="1" key3="!" key4="esc"/> |
There was a problem hiding this comment.
The western numerals are on the keyboard instead of the gujarati ones. Is this intended ?
Added Gujarati phonetic layout.
KeyModifier.javafor shift key combinationsvalues/layouts.xmlcheck_layout.outputTested debug APK build(gradle and java), working fine on my device.