-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modmap: Where to put it; cancelling built-in mods (#655) #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! As this is documentation, I've left one nick-pick. Otherwise, that's good to go.
Separately, is this section tight enough?
Also: In Swipes, the boldfacing and shading of certain of the compass points suggests there is a distinction when there isn't. At most, the center cell should be highlighted. I don't know Markdown well enough to fix this. |
Currently, the second modmap would erase the first one. This should be made into an error though and should be described as such.
No constraint on that.
Table have a mandatory header row and this is a limitation of Github Markdown. Perhaps this can be fixed by writing a raw HTML table ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The HTML tables look much better.
But all tables seem to have a default style of shading every other row, which is inappropriate here—It implies there's something special about |
That's fine ! |
No description provided.