Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modmap: Where to put it; cancelling built-in mods (#655) #666

Merged
merged 6 commits into from
Jun 22, 2024

Conversation

Spike-from-NH
Copy link
Contributor

No description provided.

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! As this is documentation, I've left one nick-pick. Otherwise, that's good to go.

doc/Custom-layouts.md Outdated Show resolved Hide resolved
@Spike-from-NH
Copy link
Contributor Author

Spike-from-NH commented Jun 20, 2024

Separately, is this section tight enough?

  • I say that "Typically" a layout has only one modmap; should this be mandatory?
  • I say the modmap is inside <keyboard> but outside any <row>. Should it be before any row?

Also: In Swipes, the boldfacing and shading of certain of the compass points suggests there is a distinction when there isn't. At most, the center cell should be highlighted. I don't know Markdown well enough to fix this.

@Julow
Copy link
Owner

Julow commented Jun 20, 2024

I say that "Typically" a layout has only one modmap; should this be mandatory?

Currently, the second modmap would erase the first one. This should be made into an error though and should be described as such.

I say the modmap is inside but outside any . Should it be before any row?

No constraint on that.

In Swipes, the boldfacing and shading of certain of the compass points suggests there is a distinction when there isn't.

Table have a mandatory header row and this is a limitation of Github Markdown. Perhaps this can be fixed by writing a raw HTML table ?

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The HTML tables look much better.

@Julow Julow merged commit ada3b5f into Julow:master Jun 22, 2024
4 checks passed
@Spike-from-NH
Copy link
Contributor Author

Thanks! The HTML tables look much better.

But all tables seem to have a default style of shading every other row, which is inappropriate here—It implies there's something special about w and e.

@Julow
Copy link
Owner

Julow commented Jun 23, 2024

That's fine !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants