Fix Slow performance of ConfigurationChangedDataRouter on trigger re-creation with many triggers #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for http://www.symmetricds.org/issues/view.php?id=2621
I found another possible improvement but maybe some else could fix this, I'm not sure if extending all those methods with a true flag is a great idea. The "bad path" is:
There
getActiveTriggerHistories
gets called for each trigger and shortly afterwardsgetActiveTriggerHistories(trigger)
for the specific trigger. I think that a small refactoring would be useful here.Sorry for the "big change" in
ITriggerRouterService.java
it seams there was a line ending missmatch in the base file.