Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slow performance of ConfigurationChangedDataRouter on trigger re-creation with many triggers #29

Merged

Conversation

woehrl01
Copy link
Contributor

@woehrl01 woehrl01 commented Jun 1, 2016

Fix for http://www.symmetricds.org/issues/view.php?id=2621

I found another possible improvement but maybe some else could fix this, I'm not sure if extending all those methods with a true flag is a great idea. The "bad path" is:

engine.getTriggerRouterService().syncTrigger(trigger, null, false);

public void syncTrigger(Trigger trigger, ITriggerCreationListener listener, boolean force, boolean verifyInDatabase)

There getActiveTriggerHistories gets called for each trigger and shortly afterwards getActiveTriggerHistories(trigger) for the specific trigger. I think that a small refactoring would be useful here.

Sorry for the "big change" in ITriggerRouterService.java it seams there was a line ending missmatch in the base file.

@erilong erilong merged commit f5bba21 into JumpMind:3.8 Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants