Delete staged resources if batch manually set to "NE" to recreate batch #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmichalek
reviewed
Oct 10, 2017
|
This causes batch corruption issues for common batches. This needs to be backed out for 3.8 and maybe a new flag can be added to force re-extraction for 3.9. |
|
If you are happy with a new flag/column, I'll create a new PR. Sorry for any inconvenience! |
|
That would be great. Can you do it on the 3.9 branch? We are going to release that in the next several weeks. |
|
Absolutely! Will do tomorrow! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leads to recreating the staged resources if a batch is manually set to "NE". This is required as according to the documentation you have to wait either until the resource times out or you have to clear the staged area, if you manually adjust the batch content on conflict or error.
With this change you can fully control the resolving scenario via sql, without having to additionally log into the application server and manually delete the file or even have to restart the service.
Additionally it ensures that any new batch is really extracted and cannot be hijacked with a random file.