0003487: Executing ISqlTemplate.update() with multiple statements swallows errors #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woehrl01
force-pushed
the
multiresultset_update
branch
from
80060cd
to
6694591
Compare
|
Thank you for that PR - definitely don't want to hide errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you execute a ISQLTemplate.update() with multiple statements at once, and one of the later statements are leading to an error (e.g. foreign key constraint violation) this exception is not thrown back to the user.
This PR reads all the result counts so that if an error is read it will be rethrown. This is also the documented behaviour of JDBC.