Contact Manager: Delete or change this line #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this line should be deleted or changed, but it's unclear which things it's referring to as actions in the company show page. We already made something called an actions class in the company index page, which refers to the links to 'show', 'edit' and 'destroy' for each company. In the context of the show page, I'm unclear as to whether it means only the 'edit' link, or if it means the 'add phone number', 'add email address' and 'edit' links, or if it means something else. I also think the way we have the links to those things separated by pipes looks better than a list. :p So, not sure how this should be changed, but I'm quite unclear as to what it actually means anyway, so I do think it probably should be changed.
VikiAnn
changed the title
worace
added a commit
that referenced
this pull request
Jan 14, 2016
Contact Manager: Delete or change this line
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this line should be deleted or changed, but it's unclear which things it's referring to as actions in the company show page.
We already made something called an actions class in the company index page, which refers to the links to 'show', 'edit' and 'destroy' for each company.
In the context of the show page, I'm unclear as to whether it means only the 'edit' link, or if it means the 'add phone number', 'add email address' and 'edit' links, or if it means something else. I also think the way we have the links to those things separated by pipes looks better than a list. :p
So, not sure how this should be changed, but I'm quite unclear as to what it actually means anyway, so I do think it probably should be changed.