12/15_点字メーカーの実装 #24
Open
12/15_点字メーカーの実装 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mfham <mfhamgithub@gmail.com>
* リファクタ - 空白を意味するMatrixを-1ではなくそのまま空白を利用する - 適宜改行する - インスタンス変数ではなく定数を利用するよう変更 - テストコード作成 * coverterのテストコード追加 * メソッドコメント追加 Co-authored-by: mfham <mfhamgithub@gmail.com>
- 企画終了まで、15日時点の状態を保つ Co-authored-by: mfham <mfhamgithub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
記事URL
https://mfham.hatenablog.com/entry/2021/12/15/235739
補足
自分のレビュー動画を見た後、手元で次のリファクタを行なって
mfham:mainブランチにマージしてしまいました。本PR元のブランチが
mfham:mainブランチであるため、本PR内容に反映されてしまいました。d55090d
bea903d
自身の担当日時点の状態で評価が行われると思いますので、評価のノイズになると思い、上記2つのリファクタ内容をrevertしました。
15366de
したがって評価時点からコミットが3つ増えております。
https://github.com/JunichiIto/tenji-maker-challenge/pull/24/commits