Callback option added to junos_jsnapy to control printing of JSNAPy info and error messages, updated jsnapy callback

[jnpr-bowen]

Added 'callback' option to junos_jsnapy to control printing of messages set in jsnapy test.
Added code in jsnapy.py to print test info and error messages contained in test
results structure. Whether error and/or info messages are printed is
controlled by the module option 'callback'.

[jnpr-bowen]

JSNAPy error messages distinguish between error from test results (error message set), error from XPath error flag set, and general error of test execution.

[stacywsmith]

@jnpr-bowen I want to merge/cherry-pick this functionality. However, this depends on JSNAPy 1.2.0. Because of the logging bug in 1.2.0, we really need to wait until the next JSNAPy release before incorporating this functionality. I'll look into this after the next JSNAPy release (which should happen fairly soon).

[jnpr-bowen]

That’s fine by me. The only way I’m able to have this work now with the logging bug is to set threads to 1. I have not done a github merge/pull request before, so I could use some pointers on the process. Later, Bruce From: "Stacy W. Smith" <notifications@github.com> Reply-To: Juniper/ansible-junos-stdlib <reply@reply.github.com> Date: Monday, November 6, 2017 at 7:49 PM To: Juniper/ansible-junos-stdlib <ansible-junos-stdlib@noreply.github.com> Cc: Bruce Bowen <bbowen@juniper.net>, Mention <mention@noreply.github.com> Subject: Re: [Juniper/ansible-junos-stdlib] Callback option added to junos_jsnapy to control printing of JSNAPy info and error messages, updated jsnapy callback (#252) @jnpr-bowen<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_jnpr-2Dbowen&d=DwMFaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=ptjBM8AbXRt86yQ7AGzHz2nOAf0dIOi1vGG0kNCnYCE&m=nBvmzmw8NYWIxb3H8bQBP9jRcKniAhte9mQg8CIIuJY&s=iyVrZ1cb37MYRyDk1iZkTUuUgezvknErREwR-34Vk9A&e=> I want to merge/cherry-pick this functionality. However, this depends on JSNAPy 1.2.0. Because of the logging bug in 1.2.0, we really need to wait until the next JSNAPy release before incorporating this functionality. I'll look into this after the next JSNAPy release (which should happen fairly soon). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Juniper_ansible-2Djunos-2Dstdlib_pull_252-23issuecomment-2D342338245&d=DwMFaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=ptjBM8AbXRt86yQ7AGzHz2nOAf0dIOi1vGG0kNCnYCE&m=nBvmzmw8NYWIxb3H8bQBP9jRcKniAhte9mQg8CIIuJY&s=UrDnM19e5FBa00SCC-6cr1Gmf6gs841T5ePneYrxBYo&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AaHmSc1joIu3n7fyxpYCwVB1CuJjTTR7ks5sz6kKgaJpZM4OkKdk&d=DwMFaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=ptjBM8AbXRt86yQ7AGzHz2nOAf0dIOi1vGG0kNCnYCE&m=nBvmzmw8NYWIxb3H8bQBP9jRcKniAhte9mQg8CIIuJY&s=kNQN0or4Zd5RwYkGLkzFLo3DFRNCV7eU0sopImk052M&e=>.

[vnitinv]

@jnpr-bowen Closing this pull request as per discussion above.