Enabling whitelist feature for jsnapy callback #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnitinv
reviewed
May 21, 2020
callback_plugins/jsnapy.py
Outdated
| @@ -20,6 +20,9 @@ class CallbackModule(CallbackBase): | |||
| CALLBACK_TYPE = 'aggregate' | |||
| CALLBACK_NAME = 'jsnapy' | |||
|
|
|||
| # only needed if you ship it and don't want to enable by default | |||
There was a problem hiding this comment.
In what context "only needed if you ship"? we are shipping callback so its not optional.
There was a problem hiding this comment.
modified the comment.
vnitinv
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding whitelist to be added in ansible.cfg for jsnapy callback to be enabled or disabled.
jsnapy callback will no more be enabled by default.