Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ignore warning for diff in juniper junos config #499

Merged
merged 5 commits into from
May 21, 2020

Conversation

rahkumar651991
Copy link
Contributor

Pass and parse the ignore_warning argument in diff for juniper_junos_config.

@vnitinv
Copy link
Contributor

vnitinv commented May 7, 2020

@rahkumar651991 @dineshbaburam91 Why our jenkins didnt run here? Can you please check this

@vnitinv
Copy link
Contributor

vnitinv commented May 8, 2020

why jenkins is not running @rahkumar651991

@vnitinv
Copy link
Contributor

vnitinv commented May 20, 2020

ok to test

Copy link
Contributor

@vnitinv vnitinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@vnitinv vnitinv merged commit f20f832 into Juniper:roles May 21, 2020
@zephyr2095
Copy link

I believe this change broke something. When I try to push config I get this error:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: TypeError: diff() got an unexpected keyword argument 'ignore_warning'

If I remove the changes made, the module works correctly.

@rahkumar651991
Copy link
Contributor Author

rahkumar651991 commented Jul 2, 2020

@zephyr2095 - It seems you will need to upgrade junos-eznc(PyEZ). It has related changes in there also.
If that doesn't work share the version details for ansible-roles and junos-eznc.

Would recommend to use juniper.junos 2.4.0 (ansible roles) and junos-eznc(2.5.0).
Multiple related changes have gone in both of them so better to avoid mismatch of versions.

@zephyr2095
Copy link

@rahkumar651991 - updating junos-eznc to 2.5.0 fixed it! Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants