Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DPDK library changes for setting control thread mask
Define a global variable ctrl_thread_set which the application can set. If this is the case, use this for setting control thread affinity instead of deducing it from the existing core pinning of the process. Depends-On: I100dccb7d2dbb86d02a36ad929b5fa571e38393f Closes-Jira-Bug: CEM-12161 Change-Id: I1122423915ca93cb76f8eef36bbf854fc08418c6
- Loading branch information
Showing
1 changed file
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b289333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference with starting your dpdk application with taskset (Linux) / cpuset (FreeBSD)?
b289333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use taskset to determine the coremask for forwarding threads only. This particular patch adds support to provide coremask for DPDK control threads as well.
b289333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the opposite way of OVS.
I can see nothing wrong with this approach, but this should have been discussed upstream.
b289333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David, we can surely discuss this in upstream. The use of taskset to determine the coremask for forwarding threads is from day-1 of vrouter-dpdk.
b289333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David, does this review look fine to you? Any comments?
b289333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you intend to upstream this patch, the discussion must happen on the dev@dpdk.org mailing list.