Change clientset to use config from config.GetConfig() #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove GetClientset and GetClientConfig in exec_to_pod.go
|
/gcbrun |
kaweue
suggested changes
Nov 23, 2020
cmd/manager/main.go
Outdated
| @@ -91,7 +91,7 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| clientset, err := v1alpha1.GetClientset() | |||
| clientset, err := v1alpha1.GetClientsetFromConfig(cfg) | |||
There was a problem hiding this comment.
In my opinion you can also delete GetClientsetFromConfig and move clientset, err := kubernetes.NewForConfig(config) here. I really don't see a point of having a function that only calls one other function.
There was a problem hiding this comment.
I changed it to kubernetes.NewForConfig(cfg).
|
/gcbrun |
kaweue
approved these changes
Nov 25, 2020
lrebeja
pushed a commit
that referenced
this pull request
Dec 2, 2020
* Change GetClientConfig function to get config from config.GetConfig * Change GetClientset to GetClientsetFromConfig in main.go Remove GetClientset and GetClientConfig in exec_to_pod.go * fix * Delete GetClientsetFromConfig * Update BUILD.bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During debugging in VS Code on cluster deployed on AWS, I was getting error that GetClientset function could not locate kubeconfig file despite providing "kubeconfig" flag and "KUBECONFIG" variable in launch.json file. After some digging I found that GetClientset uses getClientConfig function which was simply ignoring this flag and variable. I decided to get clientsert by using more direct function GetClientsetFromConfig and config gathered by config.GetConfig. I also deleted GetConfig function which was not used anywhere.