Check if no. of failed pods exceeded BackOffLimit #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that there is a bug in k8s that job-controller responsible for setting Failed Condition on Jobs does not work correctly. Sometimes the Status is not updated or updated with a huge delay. As the result multiple pods are ran and the number of them exceeds the BackOffLimit specified in Job.Spec.
This bug sometimes causes the failure of nightly job.
This PR contains a workaround that Job is assumed as Failed when it has Failed Condition set to true or the number of failed Pods i equal or greater than BackOffLimit.