Add option to provide Kubemanager env variables #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dysproz
approved these changes
Dec 15, 2020
|
recheck |
|
recheck ha |
|
recheck |
2 similar comments
|
recheck |
|
recheck |
psykulsk
reviewed
Dec 16, 2020
| @@ -220,6 +220,11 @@ func (r *ReconcileKubemanager) Reconcile(request reconcile.Request) (reconcile.R | |||
| return reconcile.Result{}, err | |||
| } | |||
|
|
|||
| _, err = instance.CreateConfigMap(request.Name+"-"+instanceType+"-configmap-envs", r.Client, r.Scheme, request) | |||
There was a problem hiding this comment.
Nit: I would create a variable, for example envVariablesConfigMap := request.Name+"-"+instanceType+"-configmap-envs" and use it here and in line 436
|
/gcbrun |
Janek3d
force-pushed
the
kubemanager-envs
branch
from
e93c24a
to
0d52903
Compare
psykulsk
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.