Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing autogen code #34

Closed
damianoneill opened this issue Jan 2, 2018 · 4 comments
Closed

Committing autogen code #34

damianoneill opened this issue Jan 2, 2018 · 4 comments
Labels

Comments

@damianoneill
Copy link
Contributor

Why are we committing autogenerated code?

On the second step, ‘make generate’ this results in new files being generated in my workspace. These files have been committed to github.

If the intent is to supported a build generated solution as well as a checkout (and everything is there) solution, then the README.md should be updated to reflect this.

@nati
Copy link
Contributor

nati commented Jan 2, 2018

because go get should work. kubernetes is doing same.

@damianoneill
Copy link
Contributor Author

Ok, but then the doc should be rewritten into two sections, one for contributors and one for users. Each section would have a different set of commands based on the intended use. I think this should be done after the section headers / descriptions are done.

@nati
Copy link
Contributor

nati commented Jan 2, 2018

yes. I agree. Could you raise new issue for that?

@nati
Copy link
Contributor

nati commented Jan 2, 2018

could you close this one if you are ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants