Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XOF_UNDERSCORES: hyphens in topmost keys are not replaced #80

Closed
jlduran opened this issue Mar 12, 2021 · 2 comments
Closed

XOF_UNDERSCORES: hyphens in topmost keys are not replaced #80

jlduran opened this issue Mar 12, 2021 · 2 comments
Assignees
@philshafer
Labels
bug

Comments

@jlduran
Copy link

jlduran commented Mar 12, 2021

Tested on FreeBSD 13 (libxo 1.4.0), when adding the underscores flag, the hyphens in the topmost keys are never underscored.

For example:

% uptime --libxo json
{"uptime-information": {"time-of-day":"10:09AM", ...

% uptime --libxo json,underscores
{"uptime-information": {"time_of_day":"10:09AM", ...

For uptime-information, the hyphen is not replaced. I am not sure if this is intended.
@philshafer philshafer self-assigned this Mar 12, 2021
@philshafer philshafer added the bug label Mar 12, 2021
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
apply "underscores" behavior to list and container open names; #80
0cc466e
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
change "top" to "top-level" for testing #80
038e3f7
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
change "top" to "top-level" for testing #80
e1bed95
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
1f0bef2
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
dee67f6
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
aea76c2
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
f2f5007
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
77135ff
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
191c55a
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
4e8910d
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
9b9418a
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
246c31e
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
c40bfde
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
595312e
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
ced8d6d
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
d8a8c83
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
fe1ad61
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
6cf25cd
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
65fbbed
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
85e89a2
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
fe60317
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
14b7bd2
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
16ea793
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
cdcc5a3
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
d7612af
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
520f6c7
philshafer added a commit that referenced this issue May 14, 2021
@philshafer
new tests for "--libxo json,underscores" (#80)
33c649d
@philshafer
Copy link
Contributor

The bug applies to all containers, not just the top one, and also to lists. Quite embarrassing, actually. Sorry it's taken so long to get cycles to address this, but the fix is now in "develop" and I'll roll a new release, that I'll then import into FB.

Thanks,
Phil

@philshafer
Copy link
Contributor

Fixed in libxo-1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philshafer philshafer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlduran @philshafer