Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug #609 - fix handling of deprecated attribute #610

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Bug #609 - fix handling of deprecated attribute #610

merged 1 commit into from
Mar 8, 2024

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Mar 8, 2024 •
edited

The special handing for use of the deprecated deploy_mode attribute wasn't set up correctly.

There was a bug in initializing a new system_attributes object where we copy the deprecated attribute.

This PR:

  • sorts some map entries (aesthetics)
  • fixes intialization of the system_attributes object
  • includes a test case which (would have) triggered this bug

Closes #609

@chrismarget-j chrismarget-j merged commit 55d0454 into main Mar 8, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the bug/609-deprecated-attribute-handling branch March 8, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwJuniper bwJuniper bwJuniper approved these changes

@rajagopalans rajagopalans Awaiting requested review from rajagopalans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apstra_datacenter_device_allocation doesn't handle deprecated attribute deploy_mode correctly
2 participants
@chrismarget-j @bwJuniper