Bug #607 make vrf_name immutable in apstra_datacenter_routing_zone resource
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
deleted the
607-resource-apstra_datacenter_routing_zone-may-be-doing-something-incorrectunsafe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notes on RFE-2747 suggest that changing the VRF name in a Routing Zone is not supported, but the
apstra_datacenter_routing_zoneresource permitted it to be changed.This PR adds a new Computed attribute
vrf_nameto theapstra_datacenter_routing_zoneresource. The initial value forvrf_nameis copied fromname, but changes tonameno longer change thevrf_nameattribute in Apstra, nor do they update thevrf_nameattribute in Terraform.vrf_nameis effectively immutable.Altogether 3 resources are modified, each with the addition of the
vrf_nameattribute:apstra_datacenter_routing_zoneresourceapstra_datacenter_routing_zonedata sourceapstra_datacenter_routing_zonesdata sourceIn addition, major re-work to the tests for the
apstra_datacenter_routing_zoneand a bunch of new test helper code we can use in other resources.Closes #607