Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toplevel debugging improvements #329

Merged
merged 2 commits into from May 4, 2020
Merged

toplevel debugging improvements #329

merged 2 commits into from May 4, 2020

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented May 1, 2020

  • set task_local_storage for toplevel debugging
  • enable "step-to-selected-line" for toplevel debugging: currently results in error

closes JunoLab/Juno.jl#569

@aviatesk aviatesk requested a review from pfitzseb May 1, 2020 18:17
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #329 into master will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   54.94%   55.00%   +0.06%     
==========================================
  Files          42       42              
  Lines        2619     2616       -3     
==========================================
  Hits         1439     1439              
+ Misses       1180     1177       -3     
Flag Coverage Δ
#unittests 55.00% <0.00%> (+0.06%) ⬆️
Impacted Files Coverage Δ
src/debugger/stepper.jl 1.38% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5d291...cce7df8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Debugger needs to set :SOURCE_PATH
2 participants