fix #7 #8
fix #7 #8
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 68.83% 69.77% +0.93%
==========================================
Files 1 1
Lines 491 493 +2
==========================================
+ Hits 338 344 +6
+ Misses 153 149 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if endswith(path, ' ') | ||
| # in order to keep type stability, we just return empty completion for this case | ||
| return Completion[], 0:-1, false | ||
| # return REPL.REPLCompletions.complete_path( |
There was a problem hiding this comment.
@fonsp
I choose your option 1, because otherwise we end up looser return type (i.e. Tuple{Union{Vector{FuzzyCompletions.Completion}, Vector{REPL.REPLCompletions.Completion}}, UnitRange{Int64}, Bool}).
If you still want to get completions for this case, can you make an additional patch on Pluto.jl side ?
There was a problem hiding this comment.
It's fine without completions, thanks!
|
@aviatesk Can you also tag a version? |
/cc @fonsp