Skip to content

Commit

Permalink
Fix <!--<!--more--> caused rendering issue gohugoio#12426
Browse files Browse the repository at this point in the history
  • Loading branch information
Junyi-99 committed Apr 26, 2024
1 parent 1961327 commit fe38d73
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
18 changes: 15 additions & 3 deletions parser/pageparser/pagelexer.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package pageparser
import (
"bytes"
"fmt"
"regexp"
"unicode"
"unicode/utf8"
)
Expand All @@ -40,7 +41,8 @@ type pageLexer struct {
cfg Config

// The summary divider to look for.
summaryDivider []byte
summaryDivider []byte
summaryDividerReg *regexp.Regexp
// Set when we have parsed any summary divider
summaryDividerChecked bool

Expand Down Expand Up @@ -96,6 +98,7 @@ func (l *pageLexer) run() *pageLexer {
var (
byteOrderMark = '\ufeff'
summaryDivider = []byte("<!--more-->")
summaryDividerReg = regexp.MustCompile("(?m)^<!--more-->")
summaryDividerOrg = []byte("# more")
delimTOML = []byte("+++")
delimYAML = []byte("---")
Expand Down Expand Up @@ -333,10 +336,11 @@ func createSectionHandlers(l *pageLexer) *sectionHandlers {
summaryDividerHandler := &sectionHandler{
l: l,
skipFunc: func(l *pageLexer) int {
if l.summaryDividerChecked || l.summaryDivider == nil {
if l.summaryDividerChecked || l.summaryDividerReg == nil {
return -1
}
return l.index(l.summaryDivider)
return l.regexIndex(l.summaryDividerReg)
//return l.index(l.summaryDivider)
},
lexFunc: func(origin stateFunc, l *pageLexer) (stateFunc, bool) {
if !l.hasPrefix(l.summaryDivider) {
Expand Down Expand Up @@ -460,6 +464,14 @@ func (l *pageLexer) index(sep []byte) int {
return bytes.Index(l.input[l.pos:], sep)
}

func (l *pageLexer) regexIndex(re *regexp.Regexp) int {
pos := re.FindIndex(l.input[l.pos:])
if pos == nil {
return -1
}
return pos[0]
}

func (l *pageLexer) hasPrefix(prefix []byte) bool {
return bytes.HasPrefix(l.input[l.pos:], prefix)
}
Expand Down
2 changes: 2 additions & 0 deletions parser/pageparser/pagelexer_intro.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package pageparser

func lexIntroSection(l *pageLexer) stateFunc {
l.summaryDivider = summaryDivider
l.summaryDividerReg = summaryDividerReg

LOOP:
for {
Expand Down Expand Up @@ -94,6 +95,7 @@ func lexFrontMatterOrgMode(l *pageLexer) stateFunc {
*/

l.summaryDivider = summaryDividerOrg
l.summaryDividerReg = summaryDividerReg

l.backup()

Expand Down

0 comments on commit fe38d73

Please sign in to comment.