Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUPITERONE_DEV environment variable only being checked for presence #575

Open
austinkelleher opened this issue Nov 16, 2021 · 0 comments
Open

JUPITERONE_DEV environment variable only being checked for presence #575

austinkelleher opened this issue Nov 16, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@austinkelleher
Copy link
Contributor

Problem

There are multiple references to process.env.JUPITERONE_DEV throughout the SDK project. Today, if a consumer of the SDK provides any value to a JUPITERONE_DEV environment variable, the consumer will target the JupiterOne development API.

We should respect the values of JUPITERONE_DEV.

Cases where the SDK should target the JupiterOne dev API:

JUPITERONE_DEV="1"
JUPITERONE_DEV="true"
JUPITERONE_DEV="TRUE"

Cases where the SDK should not target the JupiterOne dev API:

JUPITERONE_DEV="0"
JUPITERONE_DEV="false"
JUPITERONE_DEV="FALSE"
# Or when process.env.JUPITERONE_DEV is just `undefined`
@austinkelleher austinkelleher added the enhancement New feature or request label Nov 16, 2021
@austinkelleher austinkelleher added the good first issue Good for newcomers label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@austinkelleher