Skip to content

Commit

Permalink
Restore use of beginUpdateBatch/endUpdateBatch in itemTreeView notify()
Browse files Browse the repository at this point in the history
Not sure why this was disabled, but it prevents flashing of child items
when a child item is modified.
  • Loading branch information
dstillman committed Nov 28, 2017
1 parent ae21b31 commit 202192b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions chrome/content/zotero/xpcom/itemTreeView.js
Expand Up @@ -649,7 +649,7 @@ Zotero.ItemTreeView.prototype.notify = Zotero.Promise.coroutine(function* (actio
}

this.selection.selectEventsSuppressed = true;
//this._treebox.beginUpdateBatch();
this._treebox.beginUpdateBatch();

if ((action == 'remove' && !collectionTreeRow.isLibrary(true))
|| action == 'delete' || action == 'trash'
Expand Down Expand Up @@ -1020,7 +1020,7 @@ Zotero.ItemTreeView.prototype.notify = Zotero.Promise.coroutine(function* (actio

this._updateIntroText();

//this._treebox.endUpdateBatch();
this._treebox.endUpdateBatch();

// If we made changes to the selection (including reselecting the same item, which will register as
// a selection when selectEventsSuppressed is set to false), wait for a select event on the tree
Expand Down

0 comments on commit 202192b

Please sign in to comment.