Skip to content

Commit

Permalink
Simplify deleteCacheObjectVersions() query
Browse files Browse the repository at this point in the history
  • Loading branch information
dstillman committed May 3, 2017
1 parent 5b0b874 commit 2588a0a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions chrome/content/zotero/xpcom/sync/syncLocal.js
Expand Up @@ -1082,10 +1082,9 @@ Zotero.Sync.Data.Local = {
* @param {Integer} [maxVersion]
*/
deleteCacheObjectVersions: function (objectType, libraryID, key, minVersion, maxVersion) {
var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? "
+ "AND syncObjectTypeID IN (SELECT syncObjectTypeID FROM "
+ "syncObjectTypes WHERE name=?)";
var params = [libraryID, key, objectType];
var syncObjectTypeID = Zotero.Sync.Data.Utilities.getSyncObjectTypeID(objectType);
var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? AND syncObjectTypeID=?";
var params = [libraryID, key, syncObjectTypeID];
if (minVersion && minVersion == maxVersion) {
sql += " AND version=?";
params.push(minVersion);
Expand Down

0 comments on commit 2588a0a

Please sign in to comment.