Skip to content

Commit

Permalink
Support generators in tests via coMocha, instead of custom code
Browse files Browse the repository at this point in the history
* coMocha offers better error stack trace
  • Loading branch information
tnajdek authored and dstillman committed Jun 1, 2017
1 parent 14bf318 commit 289b049
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 14 deletions.
3 changes: 2 additions & 1 deletion .babelrc
Expand Up @@ -11,7 +11,8 @@
"resource/react-dom.js",
"resource/bluebird.js",
"test/resource/httpd.js",
"test/resource/mocha.js"
"test/resource/mocha.js",
"test/resource/co-mocha.js"
],
"plugins": [
"syntax-flow",
Expand Down
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -33,6 +33,7 @@
"browserify": "^14.3.0",
"chai": "^3.5.0",
"chai-as-promised": "^6.0.0",
"co-mocha": "^1.2.0",
"del": "^2.2.2",
"glob": "^7.1.2",
"gulp": "^3.9.1",
Expand Down
1 change: 1 addition & 0 deletions test/content/runtests.html
Expand Up @@ -9,6 +9,7 @@
<script src="resource://zotero-unit/chai.js"></script>
<script src="resource://zotero-unit/chai-as-promised.js"></script>
<script src="resource://zotero-unit/mocha.js"></script>
<script src="resource://zotero-unit/co-mocha.js"></script>
<script src="resource://zotero-unit/sinon.js"></script>
<script src="resource://zotero-unit/pako_inflate.js"></script>
<script src="support.js" type="application/javascript;version=1.8"></script>
Expand Down
14 changes: 1 addition & 13 deletions test/content/runtests.js
Expand Up @@ -184,19 +184,7 @@ mocha.setup({
grep: ZoteroUnit.grep
});

// Enable Bluebird generator support in Mocha
(function () {
var Runnable = Mocha.Runnable;
var run = Runnable.prototype.run;
Runnable.prototype.run = function (fn) {
if (this.fn.constructor.name === 'GeneratorFunction') {
this.fn = Zotero.Promise.coroutine(this.fn);
} else if (typeof this.fn == 'function' && this.fn.isGenerator()) {
throw new Error("Attempting to use a legacy generator in Mocha test");
}
return run.call(this, fn);
};
})();
coMocha(Mocha);

before(function () {
// Store all prefs set in runtests.sh
Expand Down
1 change: 1 addition & 0 deletions test/resource/co-mocha.js

0 comments on commit 289b049

Please sign in to comment.