Fix crash switching from Notes tab to feed item

Juris-M · Jul 27, 2017 · 72fbee5 · 72fbee5
1 parent c110e64
commit 72fbee5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/chrome/content/zotero/itemPane.js b/chrome/content/zotero/itemPane.js
@@ -98,11 +98,6 @@ var ZoteroItemPane = new function() {
 		var viewBox = document.getElementById('zotero-view-item');
 		viewBox.classList.remove('no-tabs');
 
-		// Switch to info pane for feed items
-		if (item.isFeedItem) {
-			index = viewBox.selectedIndex = 0;
-		}
-
 		if (index == 0) {
 			document.getElementById('zotero-editpane-tabs').setAttribute('hidden', item.isFeedItem);
 

diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
@@ -1472,6 +1472,12 @@ var ZoteroPane = new function()
 
 					document.getElementById('zotero-item-pane-content').selectedIndex = 1;
 					var tabBox = document.getElementById('zotero-view-tabbox');
+
+					// Reset tab when viewing a feed item, which only has the info tab
+					if (item.isFeedItem) {
+						tabBox.selectedIndex = 0;
+					}
+
 					var pane = tabBox.selectedIndex;
 					tabBox.firstChild.hidden = isCommons;