Fix sync error after resetting read-only group

If an item needed to be erased, it would fail with "Cannot edit item in read-only library", because the deletion didn't skip the edit check.
Juris-M · Dec 2, 2017 · cdaf73b · cdaf73b
1 parent 6408469
commit cdaf73b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/chrome/content/zotero/xpcom/sync/syncLocal.js b/chrome/content/zotero/xpcom/sync/syncLocal.js
@@ -277,7 +277,13 @@ Zotero.Sync.Data.Local = {
 				}
 			}
 			if (toDelete.length) {
-				yield objectsClass.erase(toDelete, { skipDeleteLog: true });
+				yield objectsClass.erase(
+					toDelete,
+					{
+						skipEditCheck: true,
+						skipDeleteLog: true
+					}
+				);
 			}
 
 			// Deleted objects

diff --git a/test/tests/syncLocalTest.js b/test/tests/syncLocalTest.js
@@ -281,6 +281,10 @@ describe("Zotero.Sync.Data.Local", function() {
 			var deletedItemKey = deletedItem.key;
 			yield deletedItem.eraseTx();
 
+			// Make group read-only
+			group.editable = false;
+			yield group.saveTx();
+
 			yield Zotero.Sync.Data.Local.resetUnsyncedLibraryData(libraryID);
 
 			assert.isNull(Zotero.SyncedSettings.get(group.libraryID, "testSetting"));