-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPC GUI fix bots collapse button #846
Conversation
Also, I just hardcoded 'display: none;' to the box-body in my latest commit. This should fix the issue with animation not displaying the first time (yeah, it is not an AdminLTE bug). |
@MrBurrBurr Please review. |
I will be home on the weekend, then I will review every PR :) |
Fixing this made me see that when a bot is farming more than one game, the images are in a carrousel (wasn't working before). But that introduces a new bug, the first time you click the + all the images are displayed for a second and only then the carrousel is dispalyed: This happens because the carrousel is initialized the first time that I don't know, what do you think @MrBurrBurr? I haven't tried any of my solutions tho, if I find free time soon I will check it better. |
I am reviewing this PR right now and noticed some things.
It is placed correctly in the current version but this issue came with upgrading AdminLTE to version 2.3.4, whenever they added a fix for box inside box collapsing error. I went back to 2.3.3 and it works again.
First I want to state that this is in fact a bug in AdminLTE. Your fix will work in this case because how the box widget is used in IPC GUI (its hidden by default). As you noticed yourself we now got the issue with the carrousel. I will have to think about what would be the best way to fix this since it wasnt coded by me but by @felipe19930. Of couse it would be appreciated if you could test any of your solutions and give feed back :) Thank you for your contribution. Please dont merge this PR. I added a part of this PR into #802. |
As per above. Thanks for review @MrBurrBurr |
If I am not wrong, the boxBodyHTML content wasn't properly placed, causing the collapse button to not work properly (collapse worked but pressing the - wasn't doing anything).