-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching badge page fails even while using risky method #3043
Comments
Same issue
|
same problem on my Openwrt Docker (Version 24.0.5) and two x64 Windows10 PCs
Debug log
|
same issue here.
EnableRiskyCardsDiscovery does not fix this issue either. |
here we go again |
Ditto, but I am not using the risky method as far as I know: it is the exact same ASF config as yesterday before the patch of: |
Issue happens to me also freshly started 5.4.11.4 (default config). I did not find and workaround yet with any settings - not sure if this is related to risky method. |
GetConfirmations() Failed! |
Looks like #3037 happened earlier than I expected: Valve completely killed session mechanism that ASF used and we need to rewrite everything we have in regards to establishing a web session - this can take some time. Yes, that's second breaking chnage they did in the last 48 hours. I'm working on it. |
ASF V5.4.12.1 has fix for this issue and web session works again. I've scheduled a release, plan is for brief (15 minutes) pre-release just to make sure it works at all, and then a stable release. |
Also big thanks to all the people that sent me extra donations for pizzas and energy drinks across those last two days, much appreciated 🙂 |
Thank you! Just in time to |
Checklist
ASF version
Latest stable release
ASF variant
win-x64
Bug description
I had ASF running for many hours using my patched version for #3029, decided to update to the official latest release and now neither of them work, requests for badge pages fail with status 400 Bad Request.
I've tried on all 3 of my devices, with clean new installs, issue persists.
I've waited some time, doesn't appear to be a steam issue because I can manually view the badges page aswell as the 2 pages ASF requests with the risky method.
EnableRiskyCardsDiscovery does not fix this issue either.
Others seem to have the same issue #3042
Expected behavior
ASF should request badge page, parse it and determine what games to farm.
Actual behavior
ASF fails to fetch the badge page, resulting in an endless loop of logging in and out.
Steps to reproduce
Start ASF with one config, default settings including OR excluding EnableRiskyCardsDiscovery.
Possible reason/solution
Maybe steam changed something required in the get request?
Can you help us with this bug report?
Yes, I can code the solution myself and send a pull request
Full log.txt recorded during reproducing the problem
Global ASF.json config file
N/A
BotName.json config of all affected bot instances
N/A
Additional info
No response
The text was updated successfully, but these errors were encountered: