Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom reverse proxy endpoints #2003

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

ezhevita
Copy link
Member

@ezhevita ezhevita commented Oct 6, 2020

Resolves the problem with setup when reverse proxy is located on other IP than localhost (e.g. running ASF in docker and nginx on the host machine) by providing user a way to configure reverse proxies (so ASF would trust X-Forwarded headers).

Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'm wondering if we shouldn't use KnownNetworks instead - it makes far more sense to allow e.g. whole LAN network rather than single IPs, and you should be able to put single IP into known network as well, since it's just /32.

ArchiSteamFarm/IPC/Startup.cs Outdated Show resolved Hide resolved
ArchiSteamFarm/IPC/Startup.cs Outdated Show resolved Hide resolved
@JustArchi JustArchi added the ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. label Oct 6, 2020
ArchiSteamFarm/IPC/Startup.cs Outdated Show resolved Hide resolved
ArchiSteamFarm/IPC/Startup.cs Outdated Show resolved Hide resolved
ArchiSteamFarm/IPC/Startup.cs Outdated Show resolved Hide resolved
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, giving it a bit more time for evaluation before merging.

@JustArchi
Copy link
Member

In the meantime please check if it behaves as you expect it to, thanks 🏆

@JustArchi JustArchi added the 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. label Oct 6, 2020
@JustArchi JustArchi added the 🏁 Finished Issues marked with this label were finished already and no further work is required on them. label Oct 6, 2020
@ezhevita
Copy link
Member Author

ezhevita commented Oct 7, 2020

Works as expected in my setup 👍

@JustArchi
Copy link
Member

JustArchi commented Oct 7, 2020

@vital7 can you show example configuration for kestrel that you've used for testing this? I want to add it to the doc, and ensure that I didn't screw up the syntax, thanks.

@ezhevita
Copy link
Member Author

ezhevita commented Oct 7, 2020

Sure:

{
  "Kestrel": {
    "Endpoints": {
      "Endpoint1": {
        "Url": "http://*:1242/"
      }
    },
    "PathBase": "/main/",
    "KnownNetworks": ["192.168.1.80/32"]
  }
}

@JustArchi JustArchi merged commit eb7889e into JustArchiNET:master Oct 7, 2020
@JustArchi
Copy link
Member

Thanks for contribution as usual 🏆

@ezhevita ezhevita deleted the custom-reverse-proxy branch October 7, 2020 18:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2020
@Abrynos Abrynos removed the 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. label Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants