-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom reverse proxy endpoints #2003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'm wondering if we shouldn't use KnownNetworks
instead - it makes far more sense to allow e.g. whole LAN network rather than single IPs, and you should be able to put single IP into known network as well, since it's just /32
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, giving it a bit more time for evaluation before merging.
In the meantime please check if it behaves as you expect it to, thanks 🏆 |
Works as expected in my setup 👍 |
@vital7 can you show example configuration for kestrel that you've used for testing this? I want to add it to the doc, and ensure that I didn't screw up the syntax, thanks. |
Sure: {
"Kestrel": {
"Endpoints": {
"Endpoint1": {
"Url": "http://*:1242/"
}
},
"PathBase": "/main/",
"KnownNetworks": ["192.168.1.80/32"]
}
} |
Thanks for contribution as usual 🏆 |
Resolves the problem with setup when reverse proxy is located on other IP than localhost (e.g. running ASF in docker and nginx on the host machine) by providing user a way to configure reverse proxies (so ASF would trust X-Forwarded headers).