Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging of invites #2005

Merged
merged 4 commits into from
Oct 7, 2020
Merged

add logging of invites #2005

merged 4 commits into from
Oct 7, 2020

Conversation

Rudokhvist
Copy link
Contributor

изображение

JustArchi
JustArchi requested changes Oct 6, 2020
View reviewed changes
ArchiSteamFarm/NLog/ArchiLogger.cs Outdated Show resolved Hide resolved
ArchiSteamFarm/NLog/ArchiLogger.cs Outdated Show resolved Hide resolved
ArchiSteamFarm/NLog/ArchiLogger.cs Outdated Show resolved Hide resolved
@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🔧 Fixes required Issues marked with this label require further follow-up fixes before they can be considered. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. labels Oct 6, 2020
JustArchi
JustArchi approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is exactly what I had in mind

@JustArchi JustArchi added 🏁 Finished Issues marked with this label were finished already and no further work is required on them. and removed 🔧 Fixes required Issues marked with this label require further follow-up fixes before they can be considered. labels Oct 7, 2020
@JustArchi JustArchi requested a review from Abrynos October 7, 2020 08:56
@JustArchi JustArchi added the 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. label Oct 7, 2020
@JustArchi
Copy link
Member

@Ryzhehvost can you verify if this final form works as expected for your use case? I don't see anything stopping it from being merged, but I want to ensure we didn't omit something crucial, thanks.

@Rudokhvist
Copy link
Contributor Author

I tested last version before pushing to github, works for me.

@JustArchi JustArchi merged commit 2a71e2c into JustArchiNET:master Oct 7, 2020
@JustArchi
Copy link
Member

Thanks for your contribution! 🏆

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2020
@Abrynos Abrynos removed the 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. label Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustArchi JustArchi JustArchi approved these changes

@Abrynos Abrynos Abrynos approved these changes

@ezhevita ezhevita ezhevita approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🏁 Finished Issues marked with this label were finished already and no further work is required on them. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rudokhvist @JustArchi @Abrynos @ezhevita