Unify WebBrowser API in regards to nullable bodies #2593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6178b12 introduced two new request options which require response content to be nullable to account for it not being parsed.
While the above change was non-breaking, it further complicates ASF logic which now has two functions that do exactly the same apart from one small detail and different response type.
It makes sense to unify those two, and while at it bullet-proof for similar problems with
HtmlDocumentResponse
where we also might need to account for null/empty HTML on error.This actually is not a breaking change per-se. Warnings will be emitted for plugin creators, but old code should still work fine without recompilation, as it was just annotation change. In terms of usage, null body might be returned only when explicitly asking for it with new request options, so even previous use cases remain valid.
I'm postponing it until next release cycle.