Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add family join confirmation type #3166

Merged

Conversation

ezhevita
Copy link
Member

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

New functionality

Add support for family join confirmation type, also log text type when encountering a confirmation with the unknown type.

Changed functionality

None

Removed functionality

None

Additional info

Logging text type is future-proofing so the log message itself would be enough to add a new type.

@ezhevita
Copy link
Member Author

full confirmation json body (numbers are partially redacted):

{
    "type": 11,
    "type_name": "Join Steam family",
    "id": "15123456789",
    "creator_id": "9021234567890123456",
    "nonce": "14071234567890123456",
    "creation_time": 1710890000,
    "cancel": "Ignore",
    "accept": "Join",
    "icon": null,
    "multi": false,
    "headline": "Join this Steam family.",
    "summary": [
        ""
    ],
    "warn": null
}

@JustArchi JustArchi merged commit 3bc66e0 into JustArchiNET:main Mar 20, 2024
21 checks passed
@JustArchi
Copy link
Member

Thanks! 🏆

@ezhevita ezhevita deleted the add-family-join-confirmation-type branch March 20, 2024 11:12
@JustArchi JustArchi added the ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. label Mar 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants