Closes #3156 #3182
Merged
Closes #3156 #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustArchi
added
✨ Enhancement
Qodana for .NET1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
ezhevita
reviewed
Apr 4, 2024
ezhevita
reviewed
Apr 4, 2024
Abrynos
reviewed
Apr 4, 2024
ezhevita
approved these changes
Apr 4, 2024
Abrynos
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the update procedure to far more robust and universal solution:
Old method:
_oldNew method:
_new_old_newfiles to target directoryCode review welcome. I've tested this with plugins update as well as ASF update and found everything to be working as it should.
Potential improvement for the future (totally outside of scope of this PR) will be to start extracting of zip file as the stream is downloaded. But this can wait, firstly we need to get new update procedure right.
Closes #3156