Skip to content

Commit

Permalink
Fix wrong determine boolean of the "hidden" attributes
Browse files Browse the repository at this point in the history 
a patch to 4009e1288a8138b2be2d235fec13f6206
  • Loading branch information
@SeaHOH
SeaHOH committed Apr 28, 2022
1 parent d881a76 commit 74179c2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bootstrap.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ if(!('any' in Promise && typeof Promise.any == 'function'))
}
Object.defineProperty(HTMLElement.prototype, "hidden", {
get: function () {
return this.getAttribute("hidden") === "hidden";
return this.hasAttribute("hidden");
},
set: function (h) {
if (h)
Expand All @@ -195,7 +195,7 @@ Object.defineProperty(HTMLElement.prototype, "hidden", {
this.removeAttribute("hidden");
}
});`;
const hashBase = "'sha256-pOEaVVaEK6o32UQn317IBBwB7SAN3UAVryFcaB2EeXY='";
const hashBase = "'sha256-S9vfb/mkBgBhAVBKLx3DRI8SDDSFSK6gcLJptX8RqDE='";
const pfFollowUp = `(function () {
// Ensure config dom.getRootNode.enabled is "false", or it would not work correctly
if (Node.prototype.getRootNode === undefined) {
Expand Down

2 comments on commit 74179c2

@Vangelis66
Copy link

@Vangelis66 Vangelis66 commented on 74179c2 Apr 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please forgive me for being pedantic 😄, but this commit's description field mentions:

a patch to 4009e1288a8138b2be2d235fec13f6206

What is exactly that string referring to?
I initially thought it is a commit hash inside this repo, but 4009e12 404s ...

Thank you once more for the highly commendable efforts put into this most valuable extension! 👍

@SeaHOH
Copy link
Collaborator Author

@SeaHOH SeaHOH commented on 74179c2 Apr 29, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for remind that.
It lost some strings, the right one is c0f5ff34009e1288a8138b2be2d235fec13f6206 c0f5ff3

Please sign in to comment.