GitHub: "Load diff" misplaced and non-clickable on many commits #46

Vangelis66 · 2022-02-19T01:28:28Z

Browser: Serpent v52.9.0 (2022-01-19) (32-bit)
[it's platform should be on par with last official Basilisk 52.9.2022.01.27 (64-bit)]
Extension version: github-wc-polyfill-v1.12.13

STR:

Load, e.g. , 3c2384b:

Load diff is misplaced (but this is something already pointed out here) 😉 , but is also overlaid with the message:

Some generated files are not rendered by default. Learn more.

Sadly, it appears that now you can only click on either "L" or "o" (of the whole Load diff string) to display the actual commit content, but those two letters are superimposed by the word "not" 😞 ...
The screenshot is from a dirty profile, but I have replicated the issue on a fresh St52 profile, with only said extension installed...

Toying a little with uBlock Origin 1.16.4.30, I removed the overlay with
github.com##.width-full.height-full.left-0.top-0.position-absolute.flex-justify-center.flex-items-center.d-flex and I thus got:

which now allows me to generate the diff by clicking on the "Lo" area, but after a tab reload, Load diff appears greyed-out and non-clickable:

I have to disable uBO on github.com, reload the tab a second time to get a non-clickable "Lo" area (due to the overlay), then re-enable uBO and reload the tab a third time to get a clickable "Lo" area (without the overlay); this is impractical ...

My instinct tells me this issue is caused by limitations in UXP's CSS/JS parsers (can't handle well the CSS code served by GitHub), so I'm not certain it could be addressed in the extension itself, but it sure is a nuisance... 😠

Any tips to mitigate the issue (e.g., some userstyle installable in Stylem/Stylus?) would be highly appreciated!

FWIW, this is how things look on a Chromium-78-based browser:

... but this is no surprise, the modern web is tailored to perfectly suit only Chromium (I consider current Firefox to be just another Chromium fork, give or take...).

As always, utmost gratitude extended to the maintainer of this extension for his unwavering efforts, especially considering current RL tensions in his neck of the woods ❤️ ...

The text was updated successfully, but these errors were encountered:

SeaHOH · 2022-02-19T02:16:12Z

Your rule is not suitable (big range), MUST only use the unique class name.

github.com##.hidden-diff-reason

JustOff · 2022-02-19T14:29:51Z

Try 1.2.14b1.

SeaHOH · 2022-02-19T23:33:30Z

The button (.load-diff-button) got an atttribute disabled when reload pages after be clicked. Reload pages using skip cache method is OK.

Vangelis66 · 2022-02-20T00:17:05Z

Apologies for the tardy replies... 😉

Your rule is not suitable (big range), MUST only use the unique class name.
github.com##.hidden-diff-reason

... As you'd probably imagine, the uBO rule I used and mentioned in my original post was not hand-written, but rather the result of using the built-in element picker...
BTW, I did try your code above, thanks, but arrived in the same results as the ones detailed in my original post (with regards to reloading the tab) ...

Try 1.2.14b1.

Many thanks for trying to address this 👍 ; I just finished a set of tests (fresh St52 profile with only 1.2.14b1 installed) and...

The misplacement issue is correctly mitigated 👍 , see below:

However, you can now load the diff by even clicking on the "blue-lined" area (header?), which means the collapse (top left) and ellipsis (top right) buttons can't be accessed without loading diff...
Loading the diff works fine, as do now the two previously mentioned buttons:

Sadly, once you reload the tab/page, the Load diff string becomes greyed-out and non-clickable, and the latter becomes also true for the "header"/buttons area (red-lined) 😢 :

This last "status" is only resolved by fully restarting the browser, as mere tab-reloads/ browser-cache-purging tried here to no avail... 😞

Hopefully, we're close to a definitive solution!
Best regards 😄

SeaHOH · 2022-02-20T03:16:10Z

This last "status" is only resolved by fully restarting the browser, as mere tab-reloads/ browser-cache-purging tried here to no avail... disappointed

Reload skip cache be activated with Ctrl + Shift + R.

rofl0r · 2022-02-20T03:28:23Z

funny, i'm seeing this too in palemoon 29.4.4 with gh polyfill 1.2.13 on this link ryanmcgrath/svgalib-1@e698d8c

SeaHOH · 2022-02-20T04:15:28Z

It also happen with 1.2.12. Maybe the bug(?)/feature of page status keeping.

JustOff · 2022-02-20T07:40:27Z

the collapse (top left) and ellipsis (top right) buttons can't be accessed without loading diff...

Try 1.2.14b2.

once you reload the tab/page, the Load diff string becomes greyed-out and non-clickable

I have no idea how to address this, fortunately, as mentioned above, Ctrl + Shift + R and Ctrl + F5 work.

SeaHOH · 2022-02-20T09:46:16Z

I have tested the old style frameworks-56f7ce131f05e8b45ad6787fd4b122c3, no issues except the disabled button.

THEtomaso · 2022-02-20T15:08:30Z

Does this uBO rule fix the issue?:
github.com##.js-diff-entry-loader:style(position: inherit !important;)

garoto · 2022-02-20T18:36:14Z

Does this uBO rule fix the issue?: github.com##.js-diff-entry-loader:style(position: inherit !important;)

It does for me while using v1.2.13 from the releases page.

Vangelis66 · 2022-02-20T18:47:02Z

funny, i'm seeing this too in palemoon 29.4.4 with gh polyfill 1.2.13

Why do you find it "funny"? 😃 Pale Moon (that's how its authors like it to be spelt 😜) is a UXP-based browser, Serpent 52 (a forked Basilisk) is built on a forked UXP which, to the best of my knowledge, bears no differences to upstream UXP as far as JS/CSS parsers are involved...

Does this uBO rule fix the issue?:
github.com##.js-diff-entry-loader:style(position: inherit !important;)

It surely does fix the misplacement 👍, with or without github-wc-polyfill-1.2.13 installed (but without this extension, clicking on Load diff does nothing, of course...).

the collapse (top left) and ellipsis (top right) buttons can't be accessed without loading diff...

Try 1.2.14b2.

Thanks! 👍 ; that solves it! 🎉

I have no idea how to address this, fortunately, as mentioned above, Ctrl + Shift + R and Ctrl + F5 work

... Sad to hear 😢 ... I'll leave this issue open for a tad longer, in the hope some bright idea 💡 comes up to someone, barring that, keyboard shortcut(s) it will be... 😉

Best wishes!

THEtomaso · 2022-02-20T19:35:45Z

It should be possible to add a fix, similar to the uBO rule which I posted, to the extension itself.

JustOff · 2022-02-20T20:05:23Z

In fact, your rule is pretty much the same as the one contained in 1.2.14b1:

.js-diff-load-container .js-diff-entry-loader {
  position: inherit !important;
}

and here is an additional fix from 1.2.14b2:

.js-skip-tagsearch > .load-diff-button, .js-skip-tagsearch > div {
  height: 75% !important;
  top: 25% !important;
}

THEtomaso · 2022-02-20T20:17:18Z

your rule is pretty much the same as the one contained in 1.2.14b1

Oh, so the remaining issue is that the fix included in your extension breaks upon page refresh?
Is that what you've now addressed in v1.2.14b2?

SeaHOH · 2022-02-20T20:41:29Z

Is that what you've now addressed in v1.2.14b2?

Big button overlay the commit box's header. #46 (comment)

SeaHOH · 2022-02-21T05:34:32Z

This injected script is working.

(function () {
  // Remove "disabled" attribute of "Load diff" buttons
  document.addEventListener('DOMContentLoaded', function () {
    for (let button of document.getElementsByClassName('load-diff-button'))
      button.removeAttribute("disabled");
  }, {once: true});
}());

misteuk · 2022-02-21T11:48:02Z

I fix in #48

Vangelis66 · 2022-02-21T23:58:57Z

This injected script is working.

Many thanks, but where exactly inside 1.2.14b2's bootstrap.js file (i.e. between which lines) should this be inserted? Can you submit a proper PR here?

I have already tried the very latest commit of your fork and it addresses fully all aspects of this issue 👍 , but your fork has diverged significantly from this ("upstream") to let a non-coder such as I easily apply your posted fix...
Hopefully JustOff will accommodate, when his RL permits... 😃

Vangelis66 · 2022-02-22T00:50:29Z

I have already tried the very latest commit of your fork and it addresses fully all aspects of this issue 👍

@SeaHOH : I just stumbled on a very minor bug of SeaHOH-gh-wc-polyfill-1.2.14, which is selectively manifested in this very issue page, i.e.

Load in a tab
GitHub: "Load diff" misplaced and non-clickable on many commits #46
With the END button (or with the scrollbar) go to the very end of the page
Reload the tab
Once the page has fully reloaded, you now find yourself not at the bottom of the page (expected behaviour), but somewhere in the middle of first (mine) post:

NB: It ONLY happens when I am logged-in !

This small "bug" isn't there with both (upstream) 1.2.14b2 or 1.2.13+PR#48 ... 😉

SeaHOH · 2022-02-22T07:38:28Z

I just stumbled on a very minor bug of SeaHOH-gh-wc-polyfill-1.2.14, which is selectively manifested in this very issue page, i.e.

Sorry, I have no idea, I can't reproduce it with my browser.

JustOff · 2022-02-27T12:28:28Z

when his RL permits...

Unfortunately, it's highly unlikely this will ever happen :-(

Vangelis66 · 2022-02-27T15:32:44Z

I can only speak for myself 😉 , since this extension has a very varied user base, but what is of paramount importance now is the safety/well-being of you, your family, your close-ones, etc,, under war conditions...

I'm afraid this isn't the right place to discuss international politics (and I believe GH doesn't allow this, in any case), so I won't, but you've done so much over the course of time 👍 with this extension, in essence providing crutches to browser platforms that can't be put up to the challenges imposed by GitHub by the browser maintainers themselves 😞 ...

Hopefully, when all dust has settled, you'll be able to revisit/address the 'disabled attribute of the "Load diff" button'; keep safe, many thanks, again, for all your work thus far! 🥇 ❤️

Vangelis66 · 2022-02-27T18:34:40Z

This injected script is working.

where exactly inside 1.2.14b2's bootstrap.js file (i.e. between which lines) should this be inserted?

With no clue myself, I ended up transforming that into a GM/VM userscript,

// ==UserScript==
// @name        Fix disabled "Load diff" button
// @namespace   https://github.com/SeaHOH
// @description Restores disabled "Load diff" area, after it has been clicked once and page reloaded (see "https://github.com/JustOff/github-wc-polyfill/issues/46#issuecomment-1046129969", item [4.] ...).
// @author      SeaHOH
// @include     /^https:\/\/github\.com\/.*\/.*\/commit\/.*$/
// @include     /^https:\/\/github\.com\/.*\/.*\/pull\/.*$/
// @run-at      document-start
// @grant       none
// @version     0.1
// @icon        https://github.githubassets.com/pinned-octocat.svg
// ==/UserScript==

(function() {
  // Remove "disabled" attribute of "Load diff" buttons
  document.addEventListener('DOMContentLoaded', function() {
    for (let button of document.getElementsByClassName('load-diff-button'))
      button.removeAttribute("disabled");
  }, {
    once: true
  });
}());

... which I'm using together with "github-wc-polyfill-v1.2.14b2" in latest Serpent 52.9.0;
works OK; thanks @SeaHOH 👍

rofl0r · 2022-02-27T20:15:41Z

someone with some skills can take @JustOff's last release (1.2.14b2), unzip it and apply the above patch to it and make it available for folks here please ?

THEtomaso · 2022-02-27T21:35:24Z

Stay safe, JustOff.

AroKol78 · 2022-02-28T15:59:54Z

(and I believe GH doesn't allow this, in any case)

https://github.com/github/feedback/discussions/12042

Stay safe, JustOff.

and everyone 🇺🇦

Vangelis66 · 2022-02-28T16:55:01Z

(and I believe GH doesn't allow this, in any case)

community/community#12042

FWIW,
https://docs.github.com/en/github/site-policy/github-community-guidelines#what-is-not-allowed
😕

Later edit: As expected, that heated discussion has been now closed/locked by GH staff... 😉
community/community#12042 (comment)
https://github.com/github/feedback/blob/main/CODE_OF_CONDUCT.md

AroKol78 · 2022-03-03T14:30:47Z

https://github.blog/2022-03-02-our-response-to-the-war-in-ukraine/

and disabled "Load diff" buttons #46 and tweak gitlab JS replace

and disabled "Load diff" buttons #46 and non-response "Copy the full SHA" buttons #49 and tweak gitlab JS replace

JustOff added bug Something isn't working help wanted Extra attention is needed labels Feb 19, 2022

Vangelis66 mentioned this issue Mar 1, 2022

"Copy the full SHA" no longer works... #49

Closed

AroKol78 mentioned this issue Mar 3, 2022

Network graph no longer works #50

Closed

SeaHOH added a commit that referenced this issue Mar 5, 2022

Workaround for no attachShadow error #48

f3d2d70

and disabled "Load diff" buttons #46 and tweak gitlab JS replace

SeaHOH added a commit that referenced this issue Mar 5, 2022

Workaround for no attachShadow error #48

d147dbb

and disabled "Load diff" buttons #46 and non-response "Copy the full SHA" buttons #49 and tweak gitlab JS replace

SeaHOH added fixed and removed help wanted Extra attention is needed labels Mar 6, 2022

SeaHOH closed this as completed Mar 6, 2022

Vangelis66 mentioned this issue Mar 7, 2022

[regression]Closed issue #46 seems to have come back... #53

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub: "Load diff" misplaced and non-clickable on many commits #46

GitHub: "Load diff" misplaced and non-clickable on many commits #46

Vangelis66 commented Feb 19, 2022

SeaHOH commented Feb 19, 2022

JustOff commented Feb 19, 2022

SeaHOH commented Feb 19, 2022 •

edited

Vangelis66 commented Feb 20, 2022

SeaHOH commented Feb 20, 2022

rofl0r commented Feb 20, 2022

SeaHOH commented Feb 20, 2022

JustOff commented Feb 20, 2022 •

edited

SeaHOH commented Feb 20, 2022 •

edited

THEtomaso commented Feb 20, 2022

garoto commented Feb 20, 2022 •

edited

Vangelis66 commented Feb 20, 2022 •

edited

THEtomaso commented Feb 20, 2022

JustOff commented Feb 20, 2022 •

edited

THEtomaso commented Feb 20, 2022 •

edited

SeaHOH commented Feb 20, 2022

SeaHOH commented Feb 21, 2022 •

edited

misteuk commented Feb 21, 2022

Vangelis66 commented Feb 21, 2022

Vangelis66 commented Feb 22, 2022 •

edited

SeaHOH commented Feb 22, 2022

JustOff commented Feb 27, 2022

Vangelis66 commented Feb 27, 2022 •

edited

Vangelis66 commented Feb 27, 2022 •

edited

rofl0r commented Feb 27, 2022

THEtomaso commented Feb 27, 2022 •

edited

AroKol78 commented Feb 28, 2022

Vangelis66 commented Feb 28, 2022 •

edited

AroKol78 commented Mar 3, 2022

GitHub: "Load diff" misplaced and non-clickable on many commits #46

GitHub: "Load diff" misplaced and non-clickable on many commits #46

Comments

Vangelis66 commented Feb 19, 2022

SeaHOH commented Feb 19, 2022

JustOff commented Feb 19, 2022

SeaHOH commented Feb 19, 2022 • edited

Vangelis66 commented Feb 20, 2022

SeaHOH commented Feb 20, 2022

rofl0r commented Feb 20, 2022

SeaHOH commented Feb 20, 2022

JustOff commented Feb 20, 2022 • edited

SeaHOH commented Feb 20, 2022 • edited

THEtomaso commented Feb 20, 2022

garoto commented Feb 20, 2022 • edited

Vangelis66 commented Feb 20, 2022 • edited

THEtomaso commented Feb 20, 2022

JustOff commented Feb 20, 2022 • edited

THEtomaso commented Feb 20, 2022 • edited

SeaHOH commented Feb 20, 2022

SeaHOH commented Feb 21, 2022 • edited

misteuk commented Feb 21, 2022

Vangelis66 commented Feb 21, 2022

Vangelis66 commented Feb 22, 2022 • edited

SeaHOH commented Feb 22, 2022

JustOff commented Feb 27, 2022

Vangelis66 commented Feb 27, 2022 • edited

Vangelis66 commented Feb 27, 2022 • edited

rofl0r commented Feb 27, 2022

THEtomaso commented Feb 27, 2022 • edited

AroKol78 commented Feb 28, 2022

Vangelis66 commented Feb 28, 2022 • edited

AroKol78 commented Mar 3, 2022

SeaHOH commented Feb 19, 2022 •

edited

JustOff commented Feb 20, 2022 •

edited

SeaHOH commented Feb 20, 2022 •

edited

garoto commented Feb 20, 2022 •

edited

Vangelis66 commented Feb 20, 2022 •

edited

JustOff commented Feb 20, 2022 •

edited

THEtomaso commented Feb 20, 2022 •

edited

SeaHOH commented Feb 21, 2022 •

edited

Vangelis66 commented Feb 22, 2022 •

edited

Vangelis66 commented Feb 27, 2022 •

edited

Vangelis66 commented Feb 27, 2022 •

edited

THEtomaso commented Feb 27, 2022 •

edited

Vangelis66 commented Feb 28, 2022 •

edited