Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove specification of python version #10

Merged
merged 2 commits into from
May 8, 2023
Merged

remove specification of python version #10

merged 2 commits into from
May 8, 2023

Conversation

miermontoto
Copy link
Contributor

python2 doesn't exist anymore, so there is no need to specify the python version. python3.10 isn't the latest version anymore as well, so this can potentially lead to crashes, as the error code of generating venv isn't checked.

@JustTemmie
Copy link
Owner

thanks for creating a pull request, yea i agree specifying 3.10 is a bit odd, though some people do still have python 2 installed on their systems for various reasons. Is there any benefit to not just specify python3 over python that i'm not aware of?

@miermontoto
Copy link
Contributor Author

python2 packages have been removed in both Fedora and Ubuntu (that I'm aware of), and the python command has been pointing to python3 for quite a while now if I recall correctly, so python3 shouldn't be necessary at all, even though I could edit the commit to specify Python3 if you want to be sure.

@JustTemmie
Copy link
Owner

yeah python2 is pretty much dead but i believe specifying python3 would be a good idea, preferably change it, thanks!

@miermontoto
Copy link
Contributor Author

done!

@JustTemmie
Copy link
Owner

thanks for the pull request! quite an awkward issue

@JustTemmie JustTemmie closed this May 8, 2023
@JustTemmie JustTemmie reopened this May 8, 2023
@JustTemmie
Copy link
Owner

fuck i know how to github

@JustTemmie JustTemmie merged commit 7ffa123 into JustTemmie:main May 8, 2023
@miermontoto miermontoto deleted the patch-1 branch May 8, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants