Add macOS support and uninstaller #28
Conversation
SpaceyKasey
commented
Aug 25, 2023
•
SpaceyKasey
commented
- Confirmed that python script works on macOS
- Added support for macOS to the install script
- Added uninstall script
SpaceyKasey
changed the title
|
this looks great, thanks! @Radiicall - are you able to test and confirm that this works on your macbook? |
I dont have my mac on hand, test it in a VM maybe |
| systemctl --user daemon-reload | ||
| systemctl --user --now enable "steam-presence.service" | ||
| # Detect OS and perform OS-specific tasks | ||
| if [[ "$OSTYPE" == "linux-gnu"* ]]; then |
There was a problem hiding this comment.
I've never seen this environment variable before?
There was a problem hiding this comment.
https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html
It is in the Bash documentation. Works on macOS but I don't have a linux env to test it rn.
installer.sh
Outdated
| systemctl --user --now enable "steam-presence.service" | ||
| elif [[ "$OSTYPE" == "darwin"* ]]; then | ||
| echo "Setting up launchd plist file for macOS" | ||
| PLIST="$HOME/Library/LaunchAgents/com.steampresence.app.plist" |
There was a problem hiding this comment.
Naming could be a bit better, for example "com" implies commercial, if you want to use that naming scheme then i would suggest "com.github.justtemmie.steam-presence.plist" because it is a more accurate description.
There was a problem hiding this comment.
I switch to com.github.justtemmie.steam-presence.plist. 'com' is the convention, although there appears to not be any hard rule for that. What about changing to 'dev' or something else? They are expecting domain-style naming.
There was a problem hiding this comment.
Naming it com.github.<author>.<project> is pretty normal in flatpaks if you know anything about those so i think that's fine
installer.sh
Outdated
| <key>Label</key> | ||
| <string>com.steampresence.app</string> |
There was a problem hiding this comment.
Label should be "Steam Presence" or "Steam-Presence"
There was a problem hiding this comment.
The label string doesnt have to match the file name, you should label it as "Steam Presence" or "Steam-Presence" so its easier to tell at a glance what the login item is for
There was a problem hiding this comment.
Got it, I updated to Steam Presence
installer.sh
Outdated
|
|
||
| echo "This script is LINUX ONLY, and it's still in testing phases, if you encounter any bugs please open an issue" | ||
| echo "This script is for LINUX and macOS, and it's still in testing phases. If you encounter any bugs, please open an issue." |
There was a problem hiding this comment.
Can you change "LINUX" to "linux", it was capitalized because it was very important that you understood that it only supported linux before
guh 😔 |
- Updated name of plist file - Updated capitalization of Linux
Did you test this on linux? |
sick, massive thanks to both of you! |
