Add ActiveScheduler.config.check_jobs_descend_from_active_job

lib/active_scheduler.rb

@@ -1,7 +1,23 @@
 require 'active_job'
+require 'active_scheduler/errors'
 require 'active_scheduler/version'
 require 'active_scheduler/resque_wrapper'
 
 module ActiveScheduler
+  Config = Struct.new(:check_jobs_descend_from_active_job)
 
+  class << self
+    def config
+      @config ||= Config.new
+    end
+
+    def configure(&block)
+      yield(config)
+    end
+  end
+
+  # Default config
+  configure do |config|
+    config.check_jobs_descend_from_active_job = true
+  end
 end

lib/active_scheduler/errors.rb

@@ -0,0 +1,4 @@
+module ActiveScheduler
+  Error = Class.new(StandardError)
+  QueueConfigMissingError = Class.new(Error)
+end

lib/active_scheduler/resque_wrapper.rb

@@ -29,10 +29,14 @@ def self.wrap(schedule)
         class_name = opts[:class] || job
         next if class_name =~ /#{self.to_s}/
 
-        klass = class_name.constantize
-        next unless klass <= ActiveJob::Base
+        if ActiveScheduler.config.check_jobs_descend_from_active_job
+          klass = class_name.constantize
+          next unless klass <= ActiveJob::Base
+          queue = opts[:queue] || klass.queue_name
+        else
+          queue = opts.fetch(:queue) { raise QueueConfigMissingError, "no queue configured for #{class_name}" }
+        end
 
-        queue = opts[:queue] || klass.queue_name
         args = opts[:args]
         named_args = opts[:named_args] || false
 

spec/active_scheduler/resque_wrapper_spec.rb

@@ -25,16 +25,48 @@
       end
 
       context "job is not an active job descendant" do
-        it "doesn't wrap" do
-          stub_const("SimpleJob", Class.new)
-          expect(wrapped['simple_job']).to eq(
-            "class"       => "SimpleJob",
-            "queue"       => "simple",
-            "description" => "It's a simple job.",
-            "every"       => "30s",
-            "rails_env"   => "test",
-            "args"        => ['foo-arg-1', 'foo-arg-2'],
-          )
+        context "with default config" do
+          it "doesn't wrap" do
+            stub_jobs("SimpleJob", base_class: Class.new)
+            expect(wrapped['simple_job']).to eq(
+              "class"       => "SimpleJob",
+              "queue"       => "simple",
+              "description" => "It's a simple job.",
+              "every"       => "30s",
+              "rails_env"   => "test",
+              "args"        => ['foo-arg-1', 'foo-arg-2'],
+            )
+          end
+        end
+
+        context "with check_jobs_descend_from_active_job configured to false" do
+          let!(:check_jobs_descend_from_active_job) do
+            ActiveScheduler.config.check_jobs_descend_from_active_job
+          end
+
+          before do
+            ActiveScheduler.config.check_jobs_descend_from_active_job = false
+          end
+
+          after do
+            ActiveScheduler.config.check_jobs_descend_from_active_job = check_jobs_descend_from_active_job
+          end
+
+          it "wraps the job" do
+            stub_jobs("SimpleJob", base_class: Class.new)
+            expect(wrapped['simple_job']).to eq(
+              "class"       => "ActiveScheduler::ResqueWrapper",
+              "queue"       => "simple",
+              "description" => "It's a simple job.",
+              "every"       => "30s",
+              "rails_env"   => "test",
+              "args"        => [{
+                "job_class"  => "SimpleJob",
+                "queue_name" => "simple",
+                "arguments"  => ['foo-arg-1', 'foo-arg-2'],
+              }]
+            )
+          end
         end
       end
 
@@ -125,14 +157,38 @@ class CustomWrapper < ActiveScheduler::ResqueWrapper
     context "when the queue is blank" do
       let(:schedule) { YAML.load_file 'spec/fixtures/no_queue.yaml' }
 
-      it "uses the job's queue" do
-        simple_job = Class.new(ActiveJob::Base) do
-          queue_as :myscheduledjobqueue
+      context "with default config" do
+        it "uses the job's queue" do
+          simple_job = Class.new(ActiveJob::Base) do
+            queue_as :myscheduledjobqueue
+          end
+
+          stub_const("SimpleJob", simple_job)
+
+          expect(wrapped['no_queue_job']['queue']).to eq 'myscheduledjobqueue'
         end
+      end
 
-        stub_const("SimpleJob", simple_job)
+      context "with check_jobs_descend_from_active_job configured to false" do
+        let!(:check_jobs_descend_from_active_job) do
+          ActiveScheduler.config.check_jobs_descend_from_active_job
+        end
 
-        expect(wrapped['no_queue_job']['queue']).to eq 'myscheduledjobqueue'
+        before do
+          ActiveScheduler.config.check_jobs_descend_from_active_job = false
+        end
+
+        after do
+          ActiveScheduler.config.check_jobs_descend_from_active_job = check_jobs_descend_from_active_job
+        end
+
+        it "raises ActiveScheduler::QueueConfigMissingError" do
+          simple_job = Class.new
+
+          stub_const("SimpleJob", simple_job)
+
+          expect { wrapped }.to raise_error(ActiveScheduler::QueueConfigMissingError)
+        end
       end
     end
 

spec/spec_helper.rb

@@ -6,9 +6,9 @@
 end
 
 module Helpers
-  def stub_jobs(*names)
+  def stub_jobs(*names, base_class: ActiveJob::Base)
     names.each do |name|
-      stub_const(name, Class.new(ActiveJob::Base))
+      stub_const(name, Class.new(base_class))
     end
   end
 end