fix: do not follow irc links (#97)

JustinBeckwith · Nov 2, 2019 · e55edb1 · e55edb1
1 parent a97b639
commit e55edb1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -51,7 +51,7 @@ export class LinkChecker extends EventEmitter {
    */
   async check(options: CheckOptions) {
     options.linksToSkip = options.linksToSkip || [];
-    options.linksToSkip.push('^mailto:');
+    options.linksToSkip.push('^mailto:', '^irc:');
     let server: http.Server | undefined;
     if (!options.path.startsWith('http')) {
       const port = options.port || 5000 + Math.round(Math.random() * 1000);

diff --git a/test/fixtures/protocols/index.html b/test/fixtures/protocols/index.html
@@ -0,0 +1,5 @@
+<html>
+<body>
+  <a href="irc://irc.freenode.net/%23bootstrap">visit us on irc</a>
+</body>
+</html>
diff --git a/test/test.ts b/test/test.ts
@@ -130,6 +130,15 @@ describe('linkinator', () => {
     assert.strictEqual(results.links.length, 2);
   });
 
+  it('should not folow non-http[s] links', async () => {
+    const results = await check({ path: 'test/fixtures/protocols' });
+    assert.ok(results.passed);
+    assert.strictEqual(
+      results.links.filter(x => x.state === LinkState.SKIPPED).length,
+      1
+    );
+  });
+
   it('should not recurse by default', async () => {
     const results = await check({ path: 'test/fixtures/recurse' });
     assert.strictEqual(results.links.length, 2);