feat: exponential backoff #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcoe
commented
Nov 11, 2021
bcoe
commented
- Adds an exponential backoff rather than just a random delay, which I think is more likely to avoid errors.
- Increases default retries to 5, so that the default maximum retry delay will be 30s (starting at 2s).
- Adds test that retries terminate.
- Partially address painful bug I bumped into trying to write tests.
bcoe
commented
Nov 11, 2021
| @@ -53,16 +53,23 @@ export class Queue extends EventEmitter { | |||
| } | |||
| // grab the element at the front of the array | |||
| const item = this.q.shift()!; | |||
| // Depending on CPU load and other factors setTimeout() is not guranteed to run exactly | |||
There was a problem hiding this comment.
setTimeout's timing is not guaranteed, I was bumping into an issue in tests where it executed a few moments before item.timeToRun, making it so tests never executed.
A better fix would be to have a long running setInterval which ensures the queue is eventually drained. This felt like a more significant change that should happen outside of this PR.
JustinBeckwith
approved these changes
Nov 11, 2021
|
🎉 This PR is included in version 2.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.