Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US-14 Merchant Invoices Index #43

Merged
merged 14 commits into from
Nov 1, 2023

Conversation

Sykogst
Copy link
Collaborator

@Sykogst Sykogst commented Oct 31, 2023

Things off the top of my head to look at

  1. I made a change to the resources in the routes file, instead of param: :merchant_id, I changed it to param: :id. The route was looking funky :merchant_merchant_id, and this got rid of that, did we want it that way?
  2. I added some relationships to the factories and a relationship tying unit_cost from items into invoice_item.
  3. The method I used to query invoices probably should be looked over, I put it in the Invoice model as it was simpler here, but I might be missing something.
  4. I have done zero formatting with the views to match the wireframes, let me know if I should add anything more or if we should revisit later.

@Sykogst Sykogst added the draft label Oct 31, 2023
@Sykogst Sykogst marked this pull request as draft October 31, 2023 22:24
@Sykogst Sykogst linked an issue Oct 31, 2023 that may be closed by this pull request
@Sykogst Sykogst marked this pull request as ready for review November 1, 2023 03:55
@Sykogst Sykogst changed the base branch from merchant to feat/merchant-invoices November 1, 2023 18:29
@Sykogst
Copy link
Collaborator Author

Sykogst commented Nov 1, 2023

merging into feat/merchant-invoices can be reviewed there

@Sykogst Sykogst merged commit f507a50 into feat/merchant-invoices Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14. Merchant Invoices Index
1 participant