Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Use uv_poll #110

Closed
wants to merge 2 commits into from
Closed

Use uv_poll #110

wants to merge 2 commits into from

Conversation

mojodna
Copy link
Contributor

@mojodna mojodna commented Jun 25, 2012

This is an initial stab to update the libuv port to use uv_poll (available in Node 0.8.x) instead of polling the socket for changes ourself. In theory, this should improve performance.

It will build against 0.8.0 (on OS X 10.7.4), but the tests are currently failing (looks like a string handling thing, not a ØMQ thing yet). I don't have time to take a deeper look, but I wanted to get this out there for others to beat on.

It's also lacking error handling.

This was referenced Jun 25, 2012
@tj
Copy link
Collaborator

tj commented Jun 25, 2012

sweet thanks, i'll have to take a look later the internet at starbucks is too slow, node-gyp is hanging on grabbing the tarball. if I dont reply remind me in a day or two

@mojodna
Copy link
Contributor Author

mojodna commented Jun 25, 2012

/cc @caili @matthiasg @gjohnson @jcayzac

@matthiasg
Copy link

thanks for the update ... will look into it this week

@ronkorving
Copy link
Collaborator

@visionmedia I don't wanna sound too impatient, but .. any news on this?

@tj
Copy link
Collaborator

tj commented Jul 4, 2012

ah yes it was merged and 2.1.0 was released, forgot to close this

@tj tj closed this Jul 4, 2012
@mojodna
Copy link
Contributor Author

mojodna commented Jul 4, 2012

Where? I don't see a merge listed in the commits. The only recent thing was the engines fix.

Probably ok, since there was still some error handling to add to this PR once its basic functionality was proven.

Have you had a chance to bench it? I was curIous about perf differences between the IOWatcher version and this.

@ronkorving
Copy link
Collaborator

Yeah, I don't see it either.

@jcayzac
Copy link

jcayzac commented Jul 4, 2012

@mojodna I had to fix a require after I merged your PR for it to work, just so you know. See my libuv-0.8 branch…

@tj
Copy link
Collaborator

tj commented Jul 4, 2012

  • | 23119c1 Seth Fitzsimmons - Use uv_poll in place of IOWatcher
  • | c3e628f Seth Fitzsimmons - Use libuv

@mojodna
Copy link
Contributor Author

mojodna commented Jul 6, 2012

@visionmedia My apologies, I missed them on a small screen. Thanks for taking a look and for merging and releasing!

@terrancesnyder terrancesnyder mentioned this pull request Nov 21, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants