This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Fixed Socket::Sendv return value bindings. #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 6.3.0 on Ubuntu 14.04 32-bit did end up with an undefined behaviour (using bool). Returning 0 (False) and 1 (True) does not have these side effects.
|
I'm lost as to why this would happen in the first place. I would like to understand the why of this. @kkoopa any ideas? |
|
Only way that would happen is if there is an ABI mismatch. Nothing to see here. |
|
@ronkorving Sounds reasonable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: The call to the socket.sendv(...) always returned false in my environment, causing a message to be send again and again (up to 32000 times).
It was incorrectly marked as not send, but my server received the first and all following messages and did reply.
Node 6.3.0 on Ubuntu 14.04 32-bit did end up with an undefined behaviour using bool type as a return value.
Returning 0 (False) and 1 (True) does not have these side effects.
Compiled with clang 3.4.