Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reproducibility] 6 of the 8 targets are skipped in benchmark notebook #20

Closed
exs-cbouy opened this issue Sep 18, 2023 · 1 comment
Closed

Comments

@exs-cbouy
Copy link

Refers to the JOSS submission review: openjournals/joss-reviews#5763

In the notebook, the first cell of the Benchmark FEPOPS using the DUDE diversity set section (third cell of the nb), the following change should be made:

diversity_set_csv_files = list(Path("data/dude/processed/diversity_set/")
-    .glob("dude_target_hiv*.csv")
+    .glob("dude_target*.csv")
)

Otherwise the notebook will only run for 2 out of 8 targets. Also the output of the same cell prints:

Got 1 diversity_set_csv_files : ['dude_target_ampc']

Although it should print out the 8 targets to be complete.

After making the above change and running the notebook I managed to reproduce the results shown in the table.

@stevenshave
Copy link
Collaborator

Thank you for being so thorough with the review, and apologies that elements from testing made it into the notebook. This has now been addressed in a13a7de and committed to the master branch with the fixed file glob pattern, and a refresh of all cell outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants