Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick change to fix #30 #31

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Quick change to fix #30 #31

merged 3 commits into from
Jul 6, 2017

Conversation

getzdan
Copy link
Contributor

@getzdan getzdan commented May 27, 2017

This is a quick fixup which was tested on latest 0.6 and master. Before merging tests on other versions are appropriate.

This is a quick fixup which was tested on latest 0.6 and master. Before merging tests on other versions are appropriate.
@coveralls
Copy link

coveralls commented May 27, 2017

Coverage Status

Coverage decreased (-0.4%) to 89.316% when pulling 7e6366d on getzdan:patch-1 into 0eb0443 on Jutho:master.

@codecov-io
Copy link

codecov-io commented May 27, 2017

Codecov Report

Merging #31 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   89.68%   89.56%   -0.12%     
==========================================
  Files          17       17              
  Lines         601      604       +3     
==========================================
+ Hits          539      541       +2     
- Misses         62       63       +1
Impacted Files Coverage Δ
src/auxiliary/meta.jl 100% <100%> (ø) ⬆️
src/indexnotation/indexedobject.jl 84.37% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb0443...3b94862. Read the comment docs.

@coveralls
Copy link

coveralls commented May 27, 2017

Coverage Status

Coverage decreased (-0.1%) to 89.57% when pulling 3b94862 on getzdan:patch-1 into 0eb0443 on Jutho:master.

@chriselrod
Copy link

chriselrod commented Jul 6, 2017

Can this be merged and a new release tagged?
Now that 0.6.0 is officially released, it would be nice to lose the deprecation warnings.

@Jutho
Copy link
Owner

Jutho commented Jul 6, 2017

Yes I forgot about this. I think this solution is ok.

@Jutho Jutho merged commit 0a19cf7 into Jutho:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants