fix(duplicated-defaults-keys): Fix Duplicated Default Keys Assigned via Object.assigbn #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s minor error, it's caused by modules using Object.assign to assign keys, which isn't picked up by the current filter
|
This PR does have the possibility of serious breakage, I am unsure if any current usage of this module actually relies upon this "bug" so I'm going to merge in such a way that this will force a 2.0 release, need to figure out the right commit type with Semantic release to make this happen. |
KJDev-Bot
added a commit
that referenced
this pull request
Feb 8, 2021
# [2.0.0](v1.7.0...v2.0.0) (2021-02-08) ### Bug Fixes * **Actions:** Fix Test action on Release Workflow ([082e58b](082e58b)) * **duplicated-defaults-keys:** Fix Duplicated Default Keys Assigned via Object.assigbn ([#217](#217)) ([5d819ce](5d819ce)) ### BREAKING CHANGES * **duplicated-defaults-keys:** This is potentially a major change, I'm uncertain if any modules or current projects actually rely upon this "bug" Please create an issue if anything is broken after this release.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was attempting to use Winston and discovered a minor error, it's caused by modules using Object.assign to assign keys, which isn't picked up by the current filter