Show state for unified alerts #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heir own functions
ivangonzalezacuna
pushed a commit
to spreadshirt/backstage-plugin-grafana
that referenced
this pull request
Apr 26, 2023
Needed an aggregation method, to not fetch the first occurrence but the most restrictive one. What does this mean? If there are 3 alert rules, and one is firing, the overall state should be firing as well, even if the other 2 are normal. This is based on the work done here: K-Phoen#54
ivangonzalezacuna
pushed a commit
to spreadshirt/backstage-plugin-grafana
that referenced
this pull request
Apr 26, 2023
Needed an aggregation method, to not fetch the first occurrence but the most restrictive one. What does this mean? If there are 3 alert rules, and one is firing, the overall state should be firing as well, even if the other 2 are normal. This is based on the work done here: K-Phoen#54 Also, added the state in the table now, instead of hidding it if the unified alerting is used
ivangonzalezacuna
pushed a commit
to spreadshirt/backstage-plugin-grafana
that referenced
this pull request
Apr 26, 2023
Needed an aggregation method, to not fetch the first occurrence but the most restrictive one. What does this mean? If there are 3 alert rules, and one is firing, the overall state should be firing as well, even if the other 2 are normal. This is based on the work done here: K-Phoen#54 Also, added the state in the table now, instead of hidding it if the unified alerting is used
ivangonzalezacuna
pushed a commit
to spreadshirt/backstage-plugin-grafana
that referenced
this pull request
Apr 26, 2023
Needed an aggregation method, to not fetch the first occurrence but the most restrictive one. What does this mean? If there are 3 alert rules, and one is firing, the overall state should be firing as well, even if the other 2 are normal. This is based on the work done here: K-Phoen#54 Also, added the state in the table now, instead of hidding it if the unified alerting is used. The method is now allowing an array of strings or a single string. This simplifies the whole call process, which should be much faster than making a call per selector foundas before
|
Looks like this feature is being reimplemented by other PRs. I'll close out this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53
I discovered that there isn't a good way to match up an alert instance to the alert rule. My best guess was to match up on the
alertnameand thealertSelector.I also wasn't sure what to do when there are multiple alert instances that matched an alert rule.